[Spring] fix required constructor missing setter to parent#23925
Open
jpfinne wants to merge 14 commits into
Open
[Spring] fix required constructor missing setter to parent#23925jpfinne wants to merge 14 commits into
jpfinne wants to merge 14 commits into
Conversation
merge master
# Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java:792">
P2: Potentially incomplete inherited-property detection: only direct parent is checked, which may miss optional properties from higher ancestors in multi-level inheritance.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| if (codegenModel.getParentModel() != null) { | ||
| codegenModel.parentRequiredVars = new ArrayList<>(codegenModel.getParentModel().requiredVars); | ||
|
|
||
| codegenModel.requiredVarsOptionalInParent = codegenModel.requiredVars.stream() |
Contributor
There was a problem hiding this comment.
P2: Potentially incomplete inherited-property detection: only direct parent is checked, which may miss optional properties from higher ancestors in multi-level inheritance.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java, line 792:
<comment>Potentially incomplete inherited-property detection: only direct parent is checked, which may miss optional properties from higher ancestors in multi-level inheritance.</comment>
<file context>
@@ -788,6 +788,13 @@ public Map<String, ModelsMap> postProcessAllModels(Map<String, ModelsMap> objs)
if (codegenModel.getParentModel() != null) {
codegenModel.parentRequiredVars = new ArrayList<>(codegenModel.getParentModel().requiredVars);
+
+ codegenModel.requiredVarsOptionalInParent = codegenModel.requiredVars.stream()
+ .filter(cp ->
+ codegenModel.getParentModel().getVars().stream()
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23918
In the required argument constructor, call the chain setters for the required fields that are not optional in the parent model.
Fix the value not initialized in the constructor.
The code works whether useOptional is true or false.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
Summary by cubic
Fixes the Spring generator so required-args constructors in child models call the parent’s chain setters when the child requires a field that’s optional in the parent. This ensures correct initialization and works with
useOptional.Written for commit 2b11518. Summary will update on new commits.